feat: Add non-navigable alert modals #37425

pedronfigueiredo · 2025-10-31T12:28:28Z

Description

Introduces a new optional alert property to hide navigation for this alert.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

hide-navigation-for-alerts.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds hideFromAlertNavigation to alerts and updates hooks/modal to skip these in navigation, with tests and usage updates.

Alert Model:
- Add optional hideFromAlertNavigation to Alert.
Hooks (useAlerts):
- Return navigableAlerts, navigableFieldAlerts, navigableGeneralAlerts, and getNavigableFieldAlerts, excluding alerts with hideFromAlertNavigation.
- Ensure severity sorting is non-mutating.
UI – MultipleAlertModal:
- Drive selection by alertKey with robust syncing/fallback logic.
- Navigate only through navigable* alerts; hide nav controls if current alert sets hideFromAlertNavigation or when skipping is requested.
- Acknowledge just triggers onFinalAcknowledgeClick (no cycling).
UI – ConfirmInfoAlertRow:
- Derive selectedAlert once; pass skipAlertNavigation based on hideFromAlertNavigation.
Alerts – Shield Coverage:
- Mark shield coverage alert with hideFromAlertNavigation: true.
Tests:
- Update/extend tests for severity ordering, navigable alert filtering, modal navigation hiding/skipping, and selection behavior.

^{Written by Cursor Bugbot for commit 22c7214. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-31T12:29:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-31T12:29:46Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (1 files, +1 -0)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 hooks/
      - 📁 alerts/
        
        📄 useShieldCoverageAlert.ts +1 -0

metamaskbot · 2025-10-31T13:33:02Z

📊 Page Load Benchmark Results

Current Commit: 32e0c24 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±39ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	43ms	1.00s	1.33s	1.04s	1.33s
domContentLoaded	717ms	39ms	692ms	990ms	725ms	990ms
firstPaint	76ms	13ms	60ms	184ms	88ms	184ms
firstContentfulPaint	76ms	13ms	60ms	184ms	88ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-31T13:33:10Z

Builds ready [32e0c24]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1272 ± 84 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1272	1112	1524	84	1320	1422
			load	1091	954	1337	80	1132	1255
			domContentLoaded	1084	951	1330	80	1128	1248
			domInteractive	21	14	80	11	20	44
			firstPaint	642	139	1338	447	1112	1212
			backgroundConnect	231	217	298	9	234	246
			firstReactRender	27	16	55	8	32	44
			getState	22	6	107	12	24	43
			initialActions	5	0	35	5	6	17
			loadScripts	860	729	1108	80	904	1022
			setupStore	10	5	27	3	11	16
			numNetworkReqs	9	6	33	7	6	30
	Browserify	Power User Home	uiStartup	2048	1628	3600	609	2570	3600
			load	1041	821	1655	329	1562	1655
			domContentLoaded	1028	814	1634	317	1531	1634
			domInteractive	25	13	60	15	42	60
			firstPaint	886	163	1685	495	1570	1685
			backgroundConnect	280	171	980	225	259	980
			firstReactRender	23	21	27	1	24	27
			getState	157	100	226	26	172	226
			initialActions	8	2	58	13	7	58
			loadScripts	828	649	1361	264	1200	1361
			setupStore	12	8	33	7	11	33
			numNetworkReqs	323	166	687	189	539	687
	Webpack	Standard Home	uiStartup	818	686	1587	100	841	918
			load	607	549	1000	77	610	752
			domContentLoaded	599	542	989	77	604	746
			domInteractive	15	11	68	8	14	32
			firstPaint	205	53	751	197	175	649
			backgroundConnect	23	13	62	8	27	34
			firstReactRender	25	16	41	7	31	35
			getState	13	6	173	17	14	18
			initialActions	3	0	8	2	4	7
			loadScripts	597	540	979	76	601	741
			setupStore	9	4	23	3	12	14
			numNetworkReqs	10	6	34	8	6	33
	Webpack	Power User Home	uiStartup	1678	1217	2638	461	2302	2638
			load	741	613	1131	177	947	1131
			domContentLoaded	704	602	1015	141	864	1015
			domInteractive	18	12	38	8	23	38
			firstPaint	435	95	1019	349	868	1019
			backgroundConnect	129	19	479	167	369	479
			firstReactRender	24	21	36	3	24	36
			getState	145	128	191	17	147	191
			initialActions	6	1	47	12	4	47
			loadScripts	700	600	1005	138	853	1005
			setupStore	19	6	77	20	28	77
			numNetworkReqs	339	196	703	180	560	703
Firefox	Browserify	Standard Home	uiStartup	1568	1346	1974	117	1623	1783
			load	1329	1163	1694	84	1370	1469
			domContentLoaded	1328	1163	1693	84	1370	1469
			domInteractive	127	36	405	55	139	242
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	26	254	27	53	77
			firstReactRender	27	22	60	5	27	32
			getState	8	4	29	4	8	13
			initialActions	4	1	9	1	4	7
			loadScripts	1299	1142	1662	82	1337	1446
			setupStore	14	4	262	25	13	17
			numNetworkReqs	9	6	35	7	7	31
	Browserify	Power User Home	uiStartup	2846	2312	4228	574	3169	4228
			load	1446	1223	1982	213	1635	1982
			domContentLoaded	1446	1223	1981	213	1635	1981
			domInteractive	174	96	336	79	249	336
			firstPaint	-	-	-	-	-	-
			backgroundConnect	244	37	711	254	567	711
			firstReactRender	53	33	102	20	69	102
			getState	139	96	199	29	151	199
			initialActions	11	1	64	15	11	64
			loadScripts	1381	1201	1745	162	1581	1745
			setupStore	45	7	163	42	69	163
			numNetworkReqs	252	149	442	91	330	442
	Webpack	Standard Home	uiStartup	1623	1451	2112	111	1690	1868
			load	1387	1233	1898	96	1442	1513
			domContentLoaded	1387	1233	1898	96	1442	1513
			domInteractive	99	43	279	36	106	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	28	134	20	53	98
			firstReactRender	32	22	79	14	32	76
			getState	11	5	185	23	7	18
			initialActions	4	2	49	6	4	13
			loadScripts	1358	1200	1793	89	1417	1483
			setupStore	13	8	56	7	13	23
			numNetworkReqs	9	6	31	7	8	30
	Webpack	Power User Home	uiStartup	2763	2392	4205	435	2899	4205
			load	1590	1348	1896	157	1722	1896
			domContentLoaded	1589	1348	1895	157	1721	1895
			domInteractive	176	81	349	93	265	349
			firstPaint	-	-	-	-	-	-
			backgroundConnect	157	38	609	163	143	609
			firstReactRender	41	30	54	7	46	54
			getState	147	82	232	40	168	232
			initialActions	19	1	149	36	13	149
			loadScripts	1536	1300	1791	136	1680	1791
			setupStore	24	9	70	19	30	70
			numNetworkReqs	244	139	402	88	323	402

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 1.18 KiB (0.02%)
common: 10 Bytes (0%)

metamaskbot · 2025-10-31T18:28:30Z

Builds ready [052c549]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1293 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1293	1118	1532	93	1351	1436
			load	1106	960	1336	92	1177	1261
			domContentLoaded	1100	955	1327	91	1171	1254
			domInteractive	20	14	63	9	19	44
			firstPaint	549	88	1258	428	1098	1192
			backgroundConnect	230	219	247	6	233	243
			firstReactRender	29	19	138	13	32	46
			getState	22	8	87	12	25	41
			initialActions	6	1	42	5	7	15
			loadScripts	877	732	1105	91	948	1026
			setupStore	11	5	29	4	11	20
			numNetworkReqs	9	6	32	7	6	30
	Browserify	Power User Home	uiStartup	2237	1819	3851	659	3019	3851
			load	1164	935	1934	342	1605	1934
			domContentLoaded	1155	929	1927	338	1586	1927
			domInteractive	28	14	60	15	43	60
			firstPaint	796	146	1734	471	999	1734
			backgroundConnect	261	218	585	87	271	585
			firstReactRender	26	23	31	2	28	31
			getState	173	151	211	15	183	211
			initialActions	8	2	57	13	6	57
			loadScripts	914	710	1510	296	1321	1510
			setupStore	12	9	35	6	13	35
			numNetworkReqs	352	202	734	200	673	734
	Webpack	Standard Home	uiStartup	848	727	1074	73	871	995
			load	642	581	893	74	644	830
			domContentLoaded	635	574	884	73	639	817
			domInteractive	15	11	47	7	14	33
			firstPaint	195	57	887	183	197	600
			backgroundConnect	22	11	57	8	24	36
			firstReactRender	26	17	60	8	32	34
			getState	12	6	29	4	14	19
			initialActions	3	0	16	2	4	7
			loadScripts	632	571	873	71	636	815
			setupStore	10	4	20	3	11	14
			numNetworkReqs	9	6	32	8	8	31
	Webpack	Power User Home	uiStartup	1677	1274	2443	366	1815	2443
			load	770	625	1291	224	819	1291
			domContentLoaded	729	611	1125	172	794	1125
			domInteractive	21	13	46	11	32	46
			firstPaint	426	82	1128	384	832	1128
			backgroundConnect	117	12	460	154	111	460
			firstReactRender	25	23	30	2	26	30
			getState	152	75	181	22	162	181
			initialActions	8	1	40	12	8	40
			loadScripts	725	609	1114	169	783	1114
			setupStore	20	6	63	17	25	63
			numNetworkReqs	310	153	610	149	519	610
Firefox	Browserify	Standard Home	uiStartup	1416	1276	1671	82	1471	1557
			load	1209	1091	1380	70	1257	1340
			domContentLoaded	1209	1090	1380	70	1257	1339
			domInteractive	105	37	246	40	118	205
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	26	70	11	49	62
			firstReactRender	25	21	52	7	25	43
			getState	7	4	40	4	7	12
			initialActions	3	1	9	1	4	5
			loadScripts	1185	1073	1352	68	1231	1322
			setupStore	13	7	199	19	12	28
			numNetworkReqs	9	6	34	7	7	31
	Browserify	Power User Home	uiStartup	2774	2291	3966	540	3168	3966
			load	1425	1182	1888	182	1570	1888
			domContentLoaded	1424	1182	1888	182	1569	1888
			domInteractive	177	98	363	84	269	363
			firstPaint	-	-	-	-	-	-
			backgroundConnect	251	50	1246	300	376	1246
			firstReactRender	47	29	90	17	59	90
			getState	137	43	202	39	153	202
			initialActions	15	1	79	24	13	79
			loadScripts	1359	1150	1592	136	1524	1592
			setupStore	36	7	195	46	36	195
			numNetworkReqs	250	156	545	108	316	545
	Webpack	Standard Home	uiStartup	1603	1384	2164	125	1639	1834
			load	1375	1198	1695	89	1422	1529
			domContentLoaded	1374	1198	1695	89	1421	1529
			domInteractive	105	33	381	57	106	249
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	24	131	16	53	77
			firstReactRender	31	22	77	14	29	71
			getState	7	3	29	3	8	13
			initialActions	5	1	89	10	4	13
			loadScripts	1347	1179	1665	88	1391	1490
			setupStore	14	7	225	22	12	33
			numNetworkReqs	9	6	32	7	7	28
	Webpack	Power User Home	uiStartup	2947	2370	4217	551	3528	4217
			load	1659	1363	2067	196	1741	2067
			domContentLoaded	1658	1362	2067	196	1741	2067
			domInteractive	163	70	341	82	228	341
			firstPaint	-	-	-	-	-	-
			backgroundConnect	266	31	941	320	711	941
			firstReactRender	44	32	76	12	53	76
			getState	123	83	207	30	137	207
			initialActions	9	1	49	13	9	49
			loadScripts	1598	1335	1932	166	1696	1932
			setupStore	35	10	203	46	39	203
			numNetworkReqs	286	139	583	160	477	583

📊 Page Load Benchmark Results

Current Commit: 052c549 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±47ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 718ms (±40ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	47ms	1.00s	1.35s	1.06s	1.35s
domContentLoaded	718ms	40ms	696ms	993ms	744ms	993ms
firstPaint	75ms	12ms	60ms	176ms	88ms	176ms
firstContentfulPaint	75ms	12ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 1.18 KiB (0.02%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T12:01:31Z

Builds ready [962e711]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1294 ± 120 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1294	1121	1869	120	1359	1486
			load	1108	955	1693	111	1169	1264
			domContentLoaded	1101	942	1679	111	1161	1257
			domInteractive	22	14	98	14	21	53
			firstPaint	666	93	1684	448	1097	1247
			backgroundConnect	233	218	270	9	238	247
			firstReactRender	31	19	58	8	38	46
			getState	23	8	95	13	26	48
			initialActions	7	1	56	8	8	20
			loadScripts	874	701	1428	109	943	1029
			setupStore	11	7	38	4	12	18
			numNetworkReqs	13	6	75	20	6	73
	Browserify	Power User Home	uiStartup	2016	1796	2627	263	2139	2627
			load	1088	933	1532	199	1349	1532
			domContentLoaded	1081	926	1525	199	1342	1525
			domInteractive	30	16	73	21	55	73
			firstPaint	510	157	1359	387	962	1359
			backgroundConnect	242	217	265	13	249	265
			firstReactRender	27	25	33	2	28	33
			getState	187	161	230	22	209	230
			initialActions	5	3	10	2	6	10
			loadScripts	853	711	1283	192	1106	1283
			setupStore	10	9	12	1	11	12
			numNetworkReqs	199	100	357	100	309	357
	Webpack	Standard Home	uiStartup	864	737	1229	100	868	1176
			load	644	587	990	87	644	939
			domContentLoaded	636	582	977	84	639	922
			domInteractive	16	11	58	8	14	35
			firstPaint	187	58	960	182	189	607
			backgroundConnect	26	11	82	15	27	70
			firstReactRender	29	18	62	9	34	45
			getState	12	7	27	4	14	19
			initialActions	4	1	37	4	4	10
			loadScripts	633	580	966	82	636	911
			setupStore	10	5	23	4	12	19
			numNetworkReqs	13	6	75	19	8	72
	Webpack	Power User Home	uiStartup	1401	1194	1984	265	1686	1984
			load	705	615	1000	117	793	1000
			domContentLoaded	687	604	956	107	758	956
			domInteractive	22	12	51	14	41	51
			firstPaint	275	93	680	185	307	680
			backgroundConnect	76	19	269	80	169	269
			firstReactRender	27	25	34	2	28	34
			getState	146	105	184	22	158	184
			initialActions	5	1	46	11	3	46
			loadScripts	682	602	945	104	746	945
			setupStore	15	6	69	15	23	69
			numNetworkReqs	167	94	293	74	274	293
Firefox	Browserify	Standard Home	uiStartup	1434	1218	1785	114	1511	1646
			load	1219	1055	1404	90	1301	1375
			domContentLoaded	1218	1055	1403	90	1301	1375
			domInteractive	117	33	358	57	122	233
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	24	157	23	49	109
			firstReactRender	25	21	57	6	25	45
			getState	7	4	21	3	7	13
			initialActions	5	1	79	11	3	13
			loadScripts	1191	1037	1374	85	1279	1340
			setupStore	11	5	32	6	11	30
			numNetworkReqs	12	6	64	16	7	60
	Browserify	Power User Home	uiStartup	2314	1978	2892	259	2491	2892
			load	1295	1118	1684	171	1469	1684
			domContentLoaded	1294	1118	1684	171	1469	1684
			domInteractive	175	84	512	139	265	512
			firstPaint	-	-	-	-	-	-
			backgroundConnect	127	30	466	119	168	466
			firstReactRender	41	27	85	15	44	85
			getState	121	72	163	27	154	163
			initialActions	7	1	19	6	14	19
			loadScripts	1254	1088	1622	163	1437	1622
			setupStore	46	8	290	68	66	290
			numNetworkReqs	169	68	283	68	240	283
	Webpack	Standard Home	uiStartup	1586	1407	2245	170	1590	2118
			load	1342	1169	1638	100	1378	1577
			domContentLoaded	1341	1168	1638	100	1378	1577
			domInteractive	99	30	217	32	112	173
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	25	321	36	52	121
			firstReactRender	33	22	78	15	32	75
			getState	11	4	184	24	7	31
			initialActions	5	1	58	8	3	25
			loadScripts	1312	1151	1555	88	1348	1503
			setupStore	16	7	209	27	11	70
			numNetworkReqs	13	6	70	18	7	68
	Webpack	Power User Home	uiStartup	2535	2130	3182	320	2755	3182
			load	1497	1223	1941	232	1755	1941
			domContentLoaded	1496	1222	1941	232	1755	1941
			domInteractive	188	79	543	171	395	543
			firstPaint	-	-	-	-	-	-
			backgroundConnect	85	32	246	69	102	246
			firstReactRender	47	33	101	16	51	101
			getState	140	96	204	38	201	204
			initialActions	10	2	32	9	17	32
			loadScripts	1465	1203	1900	223	1690	1900
			setupStore	52	7	298	72	85	298
			numNetworkReqs	154	60	323	75	217	323

📊 Page Load Benchmark Results

Current Commit: 962e711 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±51ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±49ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	51ms	1.01s	1.31s	1.05s	1.31s
domContentLoaded	722ms	49ms	699ms	991ms	742ms	991ms
firstPaint	75ms	10ms	60ms	152ms	84ms	152ms
firstContentfulPaint	75ms	10ms	60ms	152ms	84ms	152ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 1.35 KiB (0.02%)
common: 10 Bytes (0%)

metamaskbot · 2025-11-03T13:35:35Z

Builds ready [22c7214]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1290 ± 123 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1290	1103	2011	123	1350	1498
			load	1103	958	1724	108	1168	1260
			domContentLoaded	1097	953	1713	107	1161	1253
			domInteractive	24	14	342	34	20	59
			firstPaint	584	78	1273	415	1049	1170
			backgroundConnect	232	219	256	5	236	242
			firstReactRender	30	19	53	8	36	46
			getState	24	9	106	14	26	49
			initialActions	7	1	85	11	8	23
			loadScripts	870	731	1468	106	930	1028
			setupStore	12	6	38	5	12	24
			numNetworkReqs	13	6	74	20	6	73
	Browserify	Power User Home	uiStartup	2032	1789	2919	356	2432	2919
			load	1083	916	1736	231	1330	1736
			domContentLoaded	1074	909	1713	229	1325	1713
			domInteractive	26	15	75	18	41	75
			firstPaint	766	95	1750	463	989	1750
			backgroundConnect	239	218	276	16	250	276
			firstReactRender	33	24	130	25	30	130
			getState	175	160	206	12	184	206
			initialActions	5	2	14	3	6	14
			loadScripts	852	698	1479	225	1109	1479
			setupStore	12	9	27	5	11	27
			numNetworkReqs	178	104	335	93	301	335
	Webpack	Standard Home	uiStartup	878	737	1404	112	884	1206
			load	664	593	1188	108	658	966
			domContentLoaded	655	586	1174	105	651	942
			domInteractive	17	12	221	22	14	36
			firstPaint	217	57	1178	241	204	851
			backgroundConnect	26	12	89	15	27	67
			firstReactRender	28	17	91	11	33	38
			getState	12	6	27	4	14	18
			initialActions	4	0	20	3	4	11
			loadScripts	652	584	1164	103	649	932
			setupStore	10	5	19	3	12	16
			numNetworkReqs	13	6	78	19	8	71
	Webpack	Power User Home	uiStartup	1348	1198	1844	203	1516	1844
			load	700	609	1010	136	765	1010
			domContentLoaded	672	597	899	109	731	899
			domInteractive	23	13	63	17	48	63
			firstPaint	412	150	908	234	617	908
			backgroundConnect	72	18	303	86	119	303
			firstReactRender	26	25	31	1	26	31
			getState	148	111	165	18	163	165
			initialActions	4	1	11	4	8	11
			loadScripts	667	594	888	105	719	888
			setupStore	12	6	30	7	13	30
			numNetworkReqs	143	96	271	58	196	271
Firefox	Browserify	Standard Home	uiStartup	1513	1269	2107	140	1578	1769
			load	1282	1096	1583	93	1343	1449
			domContentLoaded	1282	1095	1583	93	1343	1448
			domInteractive	118	34	334	46	128	223
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	27	174	30	55	121
			firstReactRender	26	22	48	5	26	37
			getState	8	4	32	5	8	20
			initialActions	4	1	25	4	4	14
			loadScripts	1250	1078	1515	87	1314	1405
			setupStore	15	8	209	21	13	40
			numNetworkReqs	13	6	70	18	7	67
	Browserify	Power User Home	uiStartup	2562	2243	3358	407	3053	3358
			load	1403	1223	1920	212	1570	1920
			domContentLoaded	1403	1223	1920	212	1570	1920
			domInteractive	218	69	504	160	429	504
			firstPaint	-	-	-	-	-	-
			backgroundConnect	104	34	322	86	170	322
			firstReactRender	49	31	98	20	55	98
			getState	140	106	250	36	152	250
			initialActions	15	1	104	27	15	104
			loadScripts	1364	1198	1823	195	1523	1823
			setupStore	43	7	161	46	67	161
			numNetworkReqs	139	69	327	94	222	327
	Webpack	Standard Home	uiStartup	1594	1421	2097	146	1597	1962
			load	1364	1196	1712	109	1400	1613
			domContentLoaded	1363	1195	1712	109	1400	1613
			domInteractive	108	31	458	58	122	236
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	25	124	22	53	107
			firstReactRender	30	22	74	11	30	70
			getState	10	4	136	17	10	18
			initialActions	5	1	128	13	4	18
			loadScripts	1335	1179	1690	100	1378	1573
			setupStore	15	7	85	13	13	45
			numNetworkReqs	13	6	71	18	8	69
	Webpack	Power User Home	uiStartup	2537	2205	3620	366	2720	3620
			load	1496	1248	1982	203	1617	1982
			domContentLoaded	1495	1248	1982	203	1617	1982
			domInteractive	160	38	525	146	236	525
			firstPaint	-	-	-	-	-	-
			backgroundConnect	77	32	228	55	90	228
			firstReactRender	43	30	56	9	52	56
			getState	151	99	248	41	182	248
			initialActions	12	2	84	20	10	84
			loadScripts	1460	1227	1842	186	1596	1842
			setupStore	29	10	101	27	45	101
			numNetworkReqs	134	60	298	75	217	298

📊 Page Load Benchmark Results

Current Commit: 22c7214 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 745ms (±36ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	38ms	1.04s	1.34s	1.10s	1.34s
domContentLoaded	745ms	36ms	718ms	1.00s	770ms	1.00s
firstPaint	80ms	11ms	60ms	176ms	88ms	176ms
firstContentfulPaint	80ms	11ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: 1.37 KiB (0.02%)
common: 10 Bytes (0%)

pedronfigueiredo self-assigned this Oct 31, 2025

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Oct 31, 2025

pedronfigueiredo requested a review from a team as a code owner October 31, 2025 12:28

pedronfigueiredo force-pushed the pnf/alert-nav branch from 626d912 to 9be8500 Compare October 31, 2025 12:28

github-actions bot added the size-M label Oct 31, 2025

pedronfigueiredo added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 31, 2025

pedronfigueiredo force-pushed the pnf/alert-nav branch 2 times, most recently from 2803e7e to 32e0c24 Compare October 31, 2025 13:08

jpuri previously approved these changes Oct 31, 2025

View reviewed changes

pedronfigueiredo dismissed jpuri’s stale review via 052c549 October 31, 2025 17:53

pedronfigueiredo force-pushed the pnf/alert-nav branch from 32e0c24 to 052c549 Compare October 31, 2025 17:53

This comment was marked as outdated.

Sign in to view

pedronfigueiredo added 2 commits November 3, 2025 11:37

feat: Add non-navigable alert modals

1cc8eaa

wip

962e711

pedronfigueiredo force-pushed the pnf/alert-nav branch from 052c549 to 962e711 Compare November 3, 2025 11:37

wip

22c7214

jpuri approved these changes Nov 3, 2025

View reviewed changes

OGPoyraz approved these changes Nov 3, 2025

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Nov 3, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 3, 2025

pedronfigueiredo added this pull request to the merge queue Nov 3, 2025

Merged via the queue into main with commit 3c82407 Nov 3, 2025
327 of 329 checks passed

pedronfigueiredo deleted the pnf/alert-nav branch November 3, 2025 19:22

github-actions bot locked and limited conversation to collaborators Nov 3, 2025

metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add non-navigable alert modals #37425

feat: Add non-navigable alert modals #37425

pedronfigueiredo commented Oct 31, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 31, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: Add non-navigable alert modals #37425

feat: Add non-navigable alert modals #37425

Conversation

pedronfigueiredo commented Oct 31, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 31, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Oct 31, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pedronfigueiredo commented Oct 31, 2025 •

edited by cursor bot

Loading